Skip to content

Fix Node.js backtick imports and README commands#407

Open
fhwvtqdc2q-svg wants to merge 1 commit into
replit:mainfrom
fhwvtqdc2q-svg:fix-upm-open-issues
Open

Fix Node.js backtick imports and README commands#407
fhwvtqdc2q-svg wants to merge 1 commit into
replit:mainfrom
fhwvtqdc2q-svg:fix-upm-open-issues

Conversation

@fhwvtqdc2q-svg

@fhwvtqdc2q-svg fhwvtqdc2q-svg commented Jun 7, 2026

Copy link
Copy Markdown

Summary

  • Match Node.js require/import calls that use backtick string literals in GuessRegexps.
  • Add regression coverage for backtick require/import matching.
  • Make Node.js guess tests exercise the temp project directory and close temp files correctly on Windows.
  • Update Node.js guess expectations for files where the current parser still finds require/import calls after TypeScript type declarations.
  • Remove shell prompt prefixes from README command examples so copied commands run directly.
  • Add source build instructions to the README.

Fixes #405.
Addresses #363.
Addresses the source-build-instructions portion of #262.

Testing

  • git diff --check
  • go test ./internal/backends/nodejs

@fhwvtqdc2q-svg fhwvtqdc2q-svg requested a review from a team as a code owner June 7, 2026 01:07
@fhwvtqdc2q-svg fhwvtqdc2q-svg requested review from poorvapotnis and removed request for a team June 7, 2026 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Doesn't support require() statements with backtick strings for Node.js

1 participant